Skip to content

Conversation

@jstriebel
Copy link
Member

@jstriebel jstriebel commented Nov 24, 2022

This applies feedback from the ZEP1 review in PR #149 related to node names and paths:

  • removes 255 character limit for paths
  • adds note about restrictions (case insensitivity, key length limit) on underlying stores (Windows, S3, MacOS)
  • removes the /root prefix:
    • meta/root.array.json is now meta/array.json
    • meta/root/foo/bar.group.json is now meta/foo/bar.group.json

fixes #77

Note for reviewers: More changes about those topics are likely to come and discussed in different issues. A good overview of those should be #178.

@jstriebel jstriebel added the core-protocol-v3.0 Issue relates to the core protocol version 3.0 spec label Nov 24, 2022
@jstriebel jstriebel marked this pull request as ready for review November 24, 2022 17:23
@jstriebel
Copy link
Member Author

I'd love to merge this soon to avoid conflicts and to have the feedback incorporated into https://zarr-specs.readthedocs.io/en/latest/core/v3.0.html, it would be great if one of you could look into those changes @rabernat @joshmoore @alimanfoo @jakirkham @jbms.

@jstriebel jstriebel merged commit 96eb2f9 into zarr-developers:main Dec 2, 2022
@jstriebel jstriebel deleted the node-names branch December 2, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-protocol-v3.0 Issue relates to the core protocol version 3.0 spec

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

The Amazon S3 limit on the length of keys

2 participants