Use singular for "spec/codec"#119
Merged
joshmoore merged 1 commit intozarr-developers:core-protocol-v3.0-devfrom Jul 5, 2021
Merged
Use singular for "spec/codec"#119joshmoore merged 1 commit intozarr-developers:core-protocol-v3.0-devfrom
joshmoore merged 1 commit intozarr-developers:core-protocol-v3.0-devfrom
Conversation
Since https://purl.org/zarr/spec/codec/gzip/1.0 is already in the wild in xtensor-zarr and zarr_implementations, roll- back the previous choice which was based on a majority of uses in this repo. fix: zarr-developers#116
Member
Author
|
Anyone want to give this a 👍? I'd like to get this settled so if anyone else starts implementing V3 there aren't multiple values in the wild. |
Contributor
|
I would also appreciate to see this issue settled in one way or another (pretty much indifferent which solution is adopted) since the new GDAL Zarr driver is ready to be shipped (using the plural form currently): OSGeo/gdal#3896 |
Member
Author
|
Hi @rouault. Thanks for the heads up. I didn't get any 👍 for #119 (comment) but I also didn't get any 👎. I'm assuming at this point that that means no vetoes. Let's go with the singular. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since https://purl.org/zarr/spec/codec/gzip/1.0 is already
in the wild in xtensor-zarr and zarr_implementations, roll-
back the previous choice which was based on a majority of
uses in this repo.
fix: #116