Collect coverage on all Pythons #169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Seems that Python 2 was getting left out of the mix. However sometimes code needs to be special cased for Python 2. As these branches were not being counted if tested on Python 2, it caused the coverage to dip superficially. Hence this changes tox to track coverage on all Python versions and report the results.
Member
|
Thanks, I've made a PR #171 which re-instates coverage for all pythons, and also adds a pragma so coverage can be excluded based on which major python version. Previously I had just focused on PY3 and put "pragma no cover" for all PY2 code lines, hence I thought there was no point in including PY2 in coveralls, however this made me look for a way to handle exclusions better. |
Member
Author
|
Cool, your PR seems fine to me. Adding pragmas for Python versions is a nice touch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that Python 2 was getting left out of the mix. However sometimes code needs to be special cased for Python 2. As these branches were not being counted if tested on Python 2, it caused the coverage to dip superficially. Hence this changes tox to track coverage on all Python versions and report the results.