-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obstore
-based Store implementation
#1661
Open
kylebarron
wants to merge
80
commits into
zarr-developers:main
Choose a base branch
from
kylebarron:kyle/object-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
14be826
Initial object-store implementation
kylebarron a492bf0
Merge branch 'v3' into kyle/object-store
d-v-b 50b6c47
Merge branch 'v3' into kyle/object-store
jhamman afa79af
Update src/zarr/v3/store/object_store.py
kylebarron c466f9f
Merge branch 'main' into kyle/object-store
kylebarron c3e7296
Merge branch 'main' into kyle/object-store
kylebarron f5c884b
update
kylebarron af2a39b
Handle list streams
kylebarron d7cfbee
Update get
kylebarron cb40015
wip refactor get_partial_values
kylebarron 619df43
Merge branch 'main' into kyle/object-store
kylebarron b976450
Fixes to _get_partial_values
kylebarron cca70d7
Merge branch 'main' into kyle/object-store
kylebarron f2c827d
Fix constructing prototype from get
kylebarron 5c8903f
lint
kylebarron 50e1dec
Merge branch 'main' into kyle/object-store
kylebarron 8bb252e
Add docstring
kylebarron 559eafd
Make names private
kylebarron 5486e69
Implement eq
kylebarron 9a05c01
Add obstore as a test dep
maxrjones 56b7a0b
Run store tests on ObjectStore
maxrjones d5d0d4d
Merge pull request #1 from maxrjones/object-store-tests
kylebarron b38ada1
import or skip
kylebarron ab00b46
Bump obstore beta version
kylebarron 9c65e4d
bump pre-commit
kylebarron 77d7c12
Add read_only param for __init__
kylebarron 4418426
Bump obstore
maxrjones 7a71174
Add fixtures for object store tests
maxrjones e73bcc9
Cast return from __eq__ as bool
maxrjones c2cd6b8
Avoid recursion error on repr
maxrjones a95ec59
Check store type at runtime
maxrjones fb8b16d
Merge pull request #2 from maxrjones/update-tests
kylebarron ca261b1
Check if store is writable for setting or deleting objects
maxrjones 0eb416a
Add test for object store repr
maxrjones 247432f
Add attribute tests
maxrjones 4b31b3c
Add get and set methods to test class
maxrjones d49d1ff
Raise an exeption for previously set key
maxrjones c2ebc8f
Update src/zarr/testing/store.py
maxrjones eb76698
Update _transform_list_dir to not remove all items
maxrjones f310260
Return bytes from GetResult
maxrjones 86951b8
Don't raise an exception on set_if_not_exists
maxrjones f989884
Remove test that stores empty file
maxrjones 40e1b25
Handle None as start or end of byte range request
maxrjones 3aa3578
Merge pull request #3 from maxrjones/check_writable
kylebarron 6da7976
Merge branch 'main' into object-store-update
maxrjones 26fa37e
Use new ByteRequest syntax
maxrjones 315e22e
Raise not implemented error on pickling
maxrjones 264eac6
Merge pull request #4 from maxrjones/object-store-update
kylebarron fc93029
Bump obstore
maxrjones 1b9f9f2
Catch allowed exceptions
maxrjones 72c9b30
Merge pull request #5 from maxrjones/object-store
kylebarron 0f8820d
Merge branch 'main' into kyle/object-store
kylebarron f1a0534
Merge branch 'main' into kyle/object-store
maxrjones b18de38
WIP
maxrjones 6976738
Fix list dir
kylebarron 65f2db4
Merge branch 'main' into kyle/object-store
kylebarron ebf7be1
Merge branch 'kyle/object-store' into kyle/fix-transform-list-dir
kylebarron 72bf9f4
Merge pull request #6 from kylebarron/kyle/fix-transform-list-dir
kylebarron f287780
Fix failing tests
maxrjones 08b7771
Make module structure consistent with other stores
maxrjones 8038b94
Remove override of pytest parameterization
maxrjones b65d439
Use store prefix
kylebarron 1fa0125
Remove xfail for pickle
kylebarron b0b9d56
Restore pickle xfail
kylebarron aa5bdac
Mark xfail
maxrjones 01de03d
Mark xfails
maxrjones fdd7f8e
Serialization should now be supported by obstore
maxrjones 73fa459
Update equality
maxrjones 6af1e85
Bump obstore
maxrjones f4bb423
Fix serialization
maxrjones 1f7df52
Improve equality checking
maxrjones fc728a4
Merge pull request #8 from maxrjones/obstore-xfails
kylebarron 12ccb49
Update src/zarr/storage/_object.py
kylebarron 25676a3
Update src/zarr/storage/_object.py
kylebarron 4d15e43
update __eq__
kylebarron 9a25057
Fix serialization
maxrjones 9e90a02
Merge pull request #9 from maxrjones/fix-serialization
kylebarron 6f5f960
Expand test coverage
maxrjones d3ce999
Merge pull request #10 from maxrjones/improve-test-coverage
kylebarron 0fab774
Merge branch 'main' into kyle/object-store
jhamman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update to latest obstore release when we merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: obstore is currently on version 0.4.0-beta.4. I'm ready to publish 0.4.0 but wanted to ensure it works with zarr-python before publishing it.