Add API reference for V3 Implementation in the docs #1345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
Member
|
Thanks, @MSanKeys963! I imagine @ivirshup will want to take a look. I'll add here that @jstriebel was skeptical about getting this released with ZEP1 still in-flight, but this PR will at least give us a place to start prepping the docs. |
Merged
jstriebel
reviewed
Feb 10, 2023
Co-authored-by: Jonathan Striebel <[email protected]>
Co-authored-by: Jonathan Striebel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1345 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 14748 14803 +55
=========================================
+ Hits 14748 14803 +55 |
Member
|
Shall I roll this into 2.15? |
ivirshup
reviewed
Mar 10, 2023
ivirshup
reviewed
Mar 10, 2023
Co-authored-by: Jonathan Striebel <[email protected]>
Member
Author
We're good. @jstriebel, please let me know if you want me to add a separate page for sharding or if you'd like to do it. Thanks! |
Member
|
Hearing from @MSanKeys963 that @jstriebel is happy with this, I'm going to get it merged. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all. I've added the API reference for V3 implementation in the docs. This issue was raised in the community meeting on 2/8 this week.
Linking this from #1337. Preview available here: https://zarr--1345.org.readthedocs.build/en/1345/api/v3.html
Let me know what you think. Suggestions welcome.
CC: @joshmoore @grlee77 @jstriebel
TODO: