widen fill value of bytes dtype#38
Merged
normanrz merged 3 commits intozarr-developers:mainfrom Nov 17, 2025
Merged
Conversation
Member
|
+1 for this
Base64 is more compact and I'd say should be preferred. But in the near term, implementations probably want to stick with the array form until there is more implementation support. |
Contributor
Author
I added a soft recommendation for the base64 version |
Contributor
Author
|
I think this is ready for review |
normanrz
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
bytesdtype to support a base64-encoded string as a fill value. This change is motivated by compatibility with the fill values encoding used for variable-length bytes in Zarr V2 data, and also the current behavior of thevariable_length_bytesdata type in zarr-python, which I would like to deprecate in favor ofbytes.I also re-structured some of the spec for clarity.
xref zarr-developers/zarr-python#3559
I am opening this as a draft because there is content missing from this PR -- given that we have 2 different fill value encodings, we should provide a recommendation for a default when writing data. I'm happy choosing either form as the default.