Skip to content

fix: honor klog -stderrthreshold even when -logtostderr is true #4846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pierluigilenoci wants to merge 1 commit into from
Closed

fix: honor klog -stderrthreshold even when -logtostderr is true #4846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/cmd/k9s.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ func newK9sCommand() *cobra.Command {

// Mimic k9s/main.go:init()
klog.InitFlags(nil)
// Opt into the new klog behavior so that -stderrthreshold is honored even
// when -logtostderr=true (the default).
// Ref: kubernetes/klog#212, kubernetes/klog#432
flag.Set("legacy_stderr_threshold_behavior", "false") //nolint:errcheck
flag.Set("stderrthreshold", "INFO") //nolint:errcheck
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this duplicative of line 40/45

if err := flag.Set("stderrthreshold", "fatal"); err != nil {
	return err
}

Copy link
Copy Markdown
Author

@pierluigilenoci pierluigilenoci Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right on both counts, and I appreciate you taking the time to walk through this carefully.

  1. legacy_stderr_threshold_behavior: this flag only changes klog's behavior when logtostderr=true. Since this project explicitly sets logtostderr=false (line 42), the stderrthreshold is already honored by klog regardless — making the opt-in a no-op here.

  2. stderrthreshold=INFO: yes, this is immediately overwritten by stderrthreshold=fatal on line 45. Dead code.

I misread the existing code and assumed logtostderr was left at the klog default (true). The project's explicit logtostderr=false makes both additions unnecessary.

I'll close this PR. Sorry for the noise, and thanks for the thorough review.

if err := flag.Set("logtostderr", "false"); err != nil {
return err
}
Expand Down