Composability by component #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent the json schema from breaking with prior versions, making the name key optional still allows custom name mappings, but defaults to just use the same name as the main component. Also updated the json schema and shortened the name key since we are already pointing to another component.
Merged
mike-winberry
approved these changes
Mar 13, 2022
YrrepNoj
approved these changes
Mar 14, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
- refactor composing to be component specific - fixes relative path backtracking when recursively composing components - add optional name key to prevent breaking backwards compatability - handle parent component overrides Co-authored-by: Jon Perry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #384