Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Kubescape out of the Big Bang example #362

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

RothAndrew
Copy link
Contributor

Description

Removes Kubescape from the Big Bang example and documentation.

Related Issue

Fixes #361

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

It's technically breaking since it removes existing functionality but since this is an example IMO it doesn't warrant mentioning as a breaking change in release notes or any other special treatment that usually might go with breaking changes.

Checklist before merging

  • Documentation has been updated as necessary (add the needs-docs label)

@RothAndrew RothAndrew self-assigned this Mar 4, 2022
@RothAndrew RothAndrew enabled auto-merge (squash) March 4, 2022 20:30
@jeff-mccoy
Copy link
Contributor

/test all

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, makes sense to me, thanks

@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew RothAndrew merged commit 8f394b2 into master Mar 5, 2022
@RothAndrew RothAndrew deleted the feature/take-out-kubescape branch March 5, 2022 01:34
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take Kubescape out of the Big Bang example
2 participants