Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow absolute file paths on create #3518

Merged
merged 8 commits into from
Feb 21, 2025
Merged

fix: allow absolute file paths on create #3518

merged 8 commits into from
Feb 21, 2025

Conversation

AustinAbro321
Copy link
Contributor

Related Issue

Fixes #3475

Checklist before merging

@AustinAbro321
fix absolute file paths
1fa2259 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners February 19, 2025 20:43
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit dd5c1ce
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67b794cc247cf30008af9c35

@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/create.go 12.50% 6 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/import.go 44.69% <100.00%> (+1.87%) ⬆️
src/internal/packager2/layout/create.go 40.14% <12.50%> (+6.07%) ⬆️

... and 4 files with indirect coverage changes

@AustinAbro321
Copy link
Contributor Author

Moving back into draft, tests not doing what I would expect

@AustinAbro321 AustinAbro321 marked this pull request as draft February 20, 2025 16:50
@AustinAbro321
format
dd5c1ce 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
Copy link
Contributor Author

Okay should be good now

@AustinAbro321 AustinAbro321 marked this pull request as ready for review February 20, 2025 20:47
brandtkeller
brandtkeller approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ran a test of main and this branch using the issue example in order to step through the changes - saw the expected outcomes of failure on main and successful execution with these changes

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 88b5842 Feb 21, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-absolute-file-paths branch February 21, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtkeller brandtkeller brandtkeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zarf errors when absolute file paths are used in components.files.source
2 participants
@AustinAbro321 @brandtkeller