Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: trim named returns in pkg #2950 #2979

Merged
merged 16 commits into from
Sep 10, 2024

fix(pkg/cluster): partially revert 9c8e3e18eccc3a925509f4a6e335055ca3…

c4b138d
Select commit
Loading
Failed to load commit list.
Merged

refactor: trim named returns in pkg #2950 #2979

fix(pkg/cluster): partially revert 9c8e3e18eccc3a925509f4a6e335055ca3…
c4b138d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 1s

24.38% (+0.17%) compared to efa306f

View this Pull Request on Codecov

24.38% (+0.17%) compared to efa306f

Details

Codecov Report

Attention: Patch coverage is 30.49645% with 98 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/utils/cosign.go 0.00% 34 Missing ⚠️
src/pkg/layout/component.go 0.00% 13 Missing ⚠️
src/pkg/zoci/fetch.go 0.00% 11 Missing ⚠️
src/pkg/interactive/prompt.go 0.00% 10 Missing ⚠️
src/pkg/layout/sbom.go 12.50% 7 Missing ⚠️
src/pkg/interactive/components.go 0.00% 6 Missing ⚠️
src/pkg/cluster/zarf.go 0.00% 5 Missing ⚠️
src/pkg/layout/package.go 0.00% 4 Missing ⚠️
src/pkg/zoci/pull.go 0.00% 4 Missing ⚠️
src/pkg/transform/image.go 83.33% 1 Missing and 1 partial ⚠️
... and 1 more
Files with missing lines Coverage Δ
src/pkg/cluster/state.go 63.10% <100.00%> (+0.19%) ⬆️
src/pkg/lint/validate.go 92.00% <100.00%> (-0.07%) ⬇️
src/pkg/message/pausable.go 100.00% <100.00%> (ø)
src/pkg/utils/bytes.go 52.94% <100.00%> (+52.94%) ⬆️
src/pkg/utils/network.go 63.15% <100.00%> (+2.14%) ⬆️
src/pkg/transform/image.go 95.12% <83.33%> (+0.12%) ⬆️
src/pkg/variables/variables.go 78.57% <0.00%> (ø)
src/pkg/layout/package.go 36.26% <0.00%> (-0.41%) ⬇️
src/pkg/zoci/pull.go 0.00% <0.00%> (ø)
src/pkg/cluster/zarf.go 19.17% <0.00%> (-0.09%) ⬇️
... and 6 more

... and 1 file with indirect coverage changes