Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always respect the --confirm flag #297

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Always respect the --confirm flag #297

merged 4 commits into from
Feb 9, 2022

Conversation

YrrepNoj
Copy link
Contributor

@YrrepNoj YrrepNoj commented Feb 8, 2022 •
edited by jeff-mccoy
Loading

  • Check if the confirm flag has been set before prompting for components
  • Update interactive confirm to not write response to config *
  • Write explicit test to verify we can deploy a package without being prompted when the confirm flag is provided
  • This is so we can read the config.confirm value later to determine if the command is being run in 'script' mode.
    This gives us the ability to be confident if/when we can prompt the user with a question.

@YrrepNoj YrrepNoj requested a review from jeff-mccoy February 8, 2022 17:20
@YrrepNoj YrrepNoj self-assigned this Feb 8, 2022
@YrrepNoj YrrepNoj force-pushed the 200-confirm-prompting-components branch from 79c44d6 to c342ca6 Compare February 8, 2022 17:24
@YrrepNoj
Copy link
Contributor Author

YrrepNoj commented Feb 8, 2022

/test all

@YrrepNoj YrrepNoj force-pushed the 200-confirm-prompting-components branch from c342ca6 to 053fbb2 Compare February 8, 2022 17:39
@YrrepNoj
Copy link
Contributor Author

YrrepNoj commented Feb 8, 2022

/test all

@YrrepNoj
check if the confirm flag has been set before prompting for components
6b3f799
@YrrepNoj
Update interactive confirm to not write response to config
60bceab 
This is so we can read the config.confirm value later to determine if the command is being run in 'script' mode.
This gives us the ability to be confident if/when we can prompt the user with a question.
@YrrepNoj
add e2e test to verify confirm flag works
cb62afc
@YrrepNoj YrrepNoj force-pushed the 200-confirm-prompting-components branch from 053fbb2 to cb62afc Compare February 8, 2022 19:30
@YrrepNoj
Copy link
Contributor Author

YrrepNoj commented Feb 8, 2022

/test all

@YrrepNoj YrrepNoj linked an issue Feb 8, 2022 that may be closed by this pull request
--confirm not respected when deploying zarf package #200
Closed
jeff-mccoy
jeff-mccoy approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-mccoy
Copy link
Contributor

/test all

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) February 9, 2022 05:00
@jeff-mccoy jeff-mccoy merged commit 9eb207e into master Feb 9, 2022
@jeff-mccoy jeff-mccoy deleted the 200-confirm-prompting-components branch February 9, 2022 05:13
@RothAndrew RothAndrew changed the title 200 confirm prompting components Always respect the --confirm flag Feb 9, 2022
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@YrrepNoj
Normalize --confirm behavior in the CLI (#297)
ee711f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RothAndrew RothAndrew RothAndrew left review comments

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

Assignees

@YrrepNoj YrrepNoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--confirm not respected when deploying zarf package
3 participants
@YrrepNoj @jeff-mccoy @RothAndrew