Replace make_shared with new in some cases #814
Conversation
Replace make_shared for asio types that take a lib::ref as a parameter. This should fix the ASIO change (boostorg/asio@59066d8) for 1.70, while keeping it backwards compatible to older boost versions.
|
Thanks. I need a bit more time for testing, but at first glance I don't expect any issues with this. While I'd prefer to maintain the use of make_shared long term, this looks like a good solution for the moment to maintain compatibility with both new and old dependencies. |
|
Appreciate you are probably very busy, but is there any update on this? We are keen to move forward to Boost 1.70 |
Manually applied this patch: zaphoyd/websocketpp#814
|
Hello @zaphoyd is there any chance to see this merged along with a new release? |
|
Manually applying this patch seems to work fine in my app, both when using Boost 1.70 and also earlier (1.6x) versions. It may be a good idea to try to merge this, as 1.70 is now the default version in Homebrew, so many mac apps using |
Patch is cherry-picked from zaphoyd/websocketpp#814 Removed unused patches Signed-off-by: Khem Raj <[email protected]>
Patch is cherry-picked from zaphoyd/websocketpp#814 Removed unused patches Signed-off-by: Khem Raj <[email protected]>
Source: meta-openembedded MR: 00000 Type: Integration Disposition: Merged from meta-openembedded ChangeID: 55dabe2 Description: Patch is cherry-picked from zaphoyd/websocketpp#814 Removed unused patches Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Jeremy Puhlman <[email protected]>
|
@zaphoyd, can you merged this please? If you're busy or unavailable can you give someone else merge rights. |
|
Ping @zaphoyd, -its time to get a move on supporting boost 1.70+ |
|
Teset on my working project by 2 weeks, works fine |
…er and develop Mostly to capture zaphoyd/websocketpp#814
👍 on this, is there any way to get a new release please? I had to fork conan-websocketpp to apply this as a patch, getting a new release would make things much easier (cf bincrafters/conan-websocketpp#5) |
…er and develop Mostly to capture zaphoyd/websocketpp#814
|
boost incompatibility fix works for me, when is the fix expected to make it to master? |
Fix compilation for newer Boost versions, same as in the websocketpp 'develop' branch: zaphoyd/websocketpp#814 Signed-off-by: Bruno Randolf <[email protected]>
Fix compilation for newer Boost versions, same as in the websocketpp 'develop' branch: zaphoyd/websocketpp#814 Signed-off-by: Bruno Randolf <[email protected]>
Fix compilation for newer Boost versions, same as in the websocketpp 'develop' branch: zaphoyd/websocketpp#814 Signed-off-by: Bruno Randolf <[email protected]> (cherry picked from commit e1bb99f)
|
Sorry guys, can anybody explain to me how to use the head version of websocketpp to fix the building with boost 1.7 ? I just cloned cpprestsdk and ran : "git submodule update --init" to fetch websocketpp but it seems to get the release version (not head). So what should i do to get the head version ? Thanks, |
Ok, So i used: "git submodule update --init --recursive --remote". and it seems to be working :) |
Fix compilation for newer Boost versions, same as in the websocketpp 'develop' branch: zaphoyd/websocketpp#814 Signed-off-by: Bruno Randolf <[email protected]>
Fix compilation for newer Boost versions, same as in the websocketpp 'develop' branch: zaphoyd/websocketpp#814 Signed-off-by: Bruno Randolf <[email protected]>
Fix compilation for newer Boost versions, same as in the websocketpp 'develop' branch: zaphoyd/websocketpp#814 Signed-off-by: Bruno Randolf <[email protected]>
…boost 1.70+ Patch is cherry-picked from zaphoyd/websocketpp#814 Removed unused patches Signed-off-by: Khem Raj <[email protected]>
…boost 1.70+ Patch is cherry-picked from zaphoyd/websocketpp#814 Removed unused patches Signed-off-by: Khem Raj <[email protected]>
Follow up to #810, for develop branch.
Repeat issues for closing
Fixes #794
Fixes #808