Skip to content

Commit

Permalink
pwm: stm32-lp: Don't modify HW state in .remove() callback
Browse files Browse the repository at this point in the history
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

Signed-off-by: Uwe Kleine-König <[email protected]>
Signed-off-by: Thierry Reding <[email protected]>
  • Loading branch information
Uwe Kleine-König authored and thierryreding committed Sep 2, 2021
1 parent 9d768cd commit d44084c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/pwm/pwm-stm32-lp.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,6 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev)
{
struct stm32_pwm_lp *priv = platform_get_drvdata(pdev);

pwm_disable(&priv->chip.pwms[0]);

return pwmchip_remove(&priv->chip);
}

Expand Down

0 comments on commit d44084c

Please sign in to comment.