Skip to content

Commit

Permalink
drm/amdgpu: information leak in amdgpu_info_ioctl()
Browse files Browse the repository at this point in the history
We recently changed the drm_amdgpu_info_device struct so now there is
a 4 byte hole at the end.  We need to initialize it so we don't disclose
secret information from the stack.

Fixes: fa92754 ('drm/amdgpu: add VCE harvesting instance query')
Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
  • Loading branch information
Dan Carpenter authored and alexdeucher committed Jul 29, 2015
1 parent 8faf0e0 commit c193fa9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
return n ? -EFAULT : 0;
}
case AMDGPU_INFO_DEV_INFO: {
struct drm_amdgpu_info_device dev_info;
struct drm_amdgpu_info_device dev_info = {};
struct amdgpu_cu_info cu_info;

dev_info.device_id = dev->pdev->device;
Expand Down

0 comments on commit c193fa9

Please sign in to comment.