Skip to content

Commit

Permalink
nilfs2: fix memory leak in nilfs_sysfs_create_snapshot_group
Browse files Browse the repository at this point in the history
If kobject_init_and_add returns with error, kobject_put() is needed here
to avoid memory leak, because kobject_init_and_add may return error
without freeing the memory associated with the kobject it allocated.

Link: https://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Nanyong Sun <[email protected]>
Signed-off-by: Ryusuke Konishi <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
sunnanyong authored and torvalds committed Sep 8, 2021
1 parent a3e1812 commit b2fe39c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/nilfs2/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ int nilfs_sysfs_create_snapshot_group(struct nilfs_root *root)
}

if (err)
return err;
kobject_put(&root->snapshot_kobj);

return 0;
return err;
}

void nilfs_sysfs_delete_snapshot_group(struct nilfs_root *root)
Expand Down

0 comments on commit b2fe39c

Please sign in to comment.