Skip to content

Commit

Permalink
nfsd4: read encoding cleanup
Browse files Browse the repository at this point in the history
Trivial cleanup, no change in functionality.

Signed-off-by: J. Bruce Fields <[email protected]>
  • Loading branch information
J. Bruce Fields committed May 30, 2014
1 parent dc97618 commit 34a78b4
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions fs/nfsd/nfs4xdr.c
Original file line number Diff line number Diff line change
Expand Up @@ -3075,6 +3075,7 @@ static __be32 nfsd4_encode_splice_read(
struct file *file, unsigned long maxcount)
{
struct xdr_stream *xdr = &resp->xdr;
struct xdr_buf *buf = xdr->buf;
u32 eof;
int starting_len = xdr->buf->len - 8;
int space_left;
Expand All @@ -3097,37 +3098,37 @@ static __be32 nfsd4_encode_splice_read(
* page length; reset it so as not to confuse
* xdr_truncate_encode:
*/
xdr->buf->page_len = 0;
buf->page_len = 0;
return nfserr;
}

eof = (read->rd_offset + maxcount >=
read->rd_fhp->fh_dentry->d_inode->i_size);

tmp = htonl(eof);
write_bytes_to_xdr_buf(xdr->buf, starting_len , &tmp, 4);
write_bytes_to_xdr_buf(buf, starting_len , &tmp, 4);
tmp = htonl(maxcount);
write_bytes_to_xdr_buf(xdr->buf, starting_len + 4, &tmp, 4);
write_bytes_to_xdr_buf(buf, starting_len + 4, &tmp, 4);

resp->xdr.buf->page_len = maxcount;
xdr->buf->len += maxcount;
buf->page_len = maxcount;
buf->len += maxcount;
xdr->page_ptr += (maxcount + PAGE_SIZE - 1) / PAGE_SIZE;
xdr->iov = xdr->buf->tail;
xdr->iov = buf->tail;

/* Use rest of head for padding and remaining ops: */
resp->xdr.buf->tail[0].iov_base = xdr->p;
resp->xdr.buf->tail[0].iov_len = 0;
buf->tail[0].iov_base = xdr->p;
buf->tail[0].iov_len = 0;
if (maxcount&3) {
p = xdr_reserve_space(xdr, 4);
WRITE32(0);
resp->xdr.buf->tail[0].iov_base += maxcount&3;
resp->xdr.buf->tail[0].iov_len = 4 - (maxcount&3);
xdr->buf->len -= (maxcount&3);
buf->tail[0].iov_base += maxcount&3;
buf->tail[0].iov_len = 4 - (maxcount&3);
buf->len -= (maxcount&3);
}

space_left = min_t(int, (void *)xdr->end - (void *)xdr->p,
xdr->buf->buflen - xdr->buf->len);
xdr->buf->buflen = xdr->buf->len + space_left;
buf->buflen - buf->len);
buf->buflen = buf->len + space_left;
xdr->end = (__be32 *)((void *)xdr->end + space_left);

return 0;
Expand Down

0 comments on commit 34a78b4

Please sign in to comment.