Fix api_proxy delete method to only succeed when proxy is deleted #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the delete method fails to delete the proxy it still claims to have succeeded and removes the proxy from state. For example, when a proxy has a deployment associated with it, it cannot be deleted. This was due to a small bug in the delete method. Added a test to check this behaviour.
daniel-ds
force-pushed
the
fix-proxy-delete
branch
from
a639e9e to
c58b43f
Compare
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the delete method fails to delete the proxy it still claims to have succeeded and removes the proxy from state.
For example, when a proxy has a deployment associated with it it cannot be deleted.
This was due to a small bug in the delete method.
Added a test to check this behaviour.