Concrete Keygen in Rust #1198
Open
Concrete Keygen in Rust #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
force-pushed
the
feat/keygen-from-tfhers
branch
from
2fce9dc to
c59d101
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: ea5d0fd | Previous: 8704ff8 | Ratio |
|---|---|---|---|
v0 PBS table generation |
58966332 ns/iter (± 1773888) |
58734887 ns/iter (± 505931) |
1.00 |
v0 PBS simulate dag table generation |
37935830 ns/iter (± 490235) |
37418545 ns/iter (± 362974) |
1.01 |
v0 WoP-PBS table generation |
53801528 ns/iter (± 577218) |
53928255 ns/iter (± 1171398) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
BourgerieQuentin
requested changes
Jan 20, 2025
| .def( | ||
| "serialize", | ||
| [](KeysetInfo &keySetInfo) { | ||
| auto keySetInfoSerialize = [](KeysetInfo &keysetInfo) { |
There was a problem hiding this comment.
why are you using a lambda here?
| f"{os.path.dirname(os.path.abspath(__file__))}" | ||
| "/../../../../tools/concrete-rust/target/release/concrete-rust-keygen" | ||
| ) | ||
| os.system(f"{bin_path} {keyinfo_path} {keyset_path}") |
| /// | ||
| /// # Returns | ||
| /// A Cap'n Proto message containing the generated keyset. | ||
| fn generate_keyset_message( |
There was a problem hiding this comment.
maybe outline some logics here?
| /// | ||
| /// # Panics | ||
| /// This function panics if it fails to open the keyset info file or create the keyset file. | ||
| pub fn generate_keyset( |
There was a problem hiding this comment.
I think method with path should not be in the lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.