chore: add load tfhers params from dict #1196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
andrei-stoian-zama
force-pushed
the
chore/add_load_tfhers_params_dict
branch
from
fa8e17a to
892b6d9
Compare
youben11
requested changes
Jan 14, 2025
Comment on lines
19
to
38
| PARAMS_DICT = { | ||
| "lwe_dimension": 902, | ||
| "glwe_dimension": 1, | ||
| "polynomial_size": 4096, | ||
| "lwe_noise_distribution": {"Gaussian": {"std": 1.0994794733558207e-6, "mean": 0.0}}, | ||
| "glwe_noise_distribution": {"Gaussian": {"std": 2.168404344971009e-19, "mean": 0.0}}, | ||
| "pbs_base_log": 15, | ||
| "pbs_level": 2, | ||
| "ks_base_log": 3, | ||
| "ks_level": 6, | ||
| "message_modulus": 4, | ||
| "carry_modulus": 8, | ||
| "max_noise_level": 10, | ||
| "log2_p_fail": -64.084, | ||
| "ciphertext_modulus": {"modulus": 0, "scalar_bits": 64}, | ||
| "encryption_key_choice": "Big", | ||
| } | ||
|
|
||
| tfhers_type = tfhers.get_type_from_params_dict( | ||
| PARAMS_DICT, |
There was a problem hiding this comment.
We shouldn't update the example. There are explained steps to generate the file with TFHE-rs parameters in Rust. The motivation for that was to remove parameters completely from the Python file, but this is re-introducing them.
There was a problem hiding this comment.
ok, makes sense
youben11
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
LGTM! You can just green the CI and merge. It is failing for two reasons currently:
- commit message compliance: second commit is not compliant, but I guess you could squash it locally and force-push
- API has changed, so docs need to be updated: you can either run the docgen locally, but this might become a nightmare depending on what you use locally. Or you can just apply the patch provided in the logs.
Thanks @andrei-stoian-zama
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.