-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#27 pycsw single microservice #34
Conversation
The service port is not configurable.
waiting for GeoNode/geonode#11319 . meanwhile you can use the following geonode image including the bugfix promoted inside the PR.
|
GeoNode/geonode#11319 got merged, so no reason to hold this back anymore |
name: {{ .Release.Name }}-pycsw-cfg | ||
namespace: {{ .Release.Namespace }} | ||
data: | ||
pycsw.cfg: |+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we better include that configuration as is in the values.yml and embed the config via {{- include "pycsw.config" . | nindent 4 }}
?
|
||
The pycsw configuration (pycsw.cfg) and mappings are defined in the values file: `[ .Values.pycsw.config , .Values.pycsw.mappings ]` | ||
|
||
The csw endpoint is default set to the one used within Geonode: `/catalogue/csw` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a link reference here, e.g. https://docs.pycsw.org/en/2.6.1/configuration.html
@@ -30,6 +30,9 @@ geonode: | |||
email_verification: "False" | |||
authentication_method: username_email | |||
|
|||
pycsw: | |||
enabled: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have to resolve #64 first, but at least should have a look at the way how the config is embedded in the configMap
Closes #27
📑 Description
ref #27
added pycsw microservice inspired by pycsw helm chart (https://github.com/geopython/pycsw/tree/master/docker/helm) with adoption to the style of this helm chart.
Implementation:
.Values.pycsw.endpoint
urlℹ Additional Information