Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #190] Bug: nginx livenessProbe always kill nginx container, when using externalscheme: https #196

Conversation

mwallschlaeger
Copy link
Contributor

Description

this PR fixes an issue when running geonode-k8s with geonode.general.externalScheme. With this configuration the nginx container gets constantly killed as the liveness probes tries to reach http on a wrong port.

Additionally I increased the initialDelaySeconds of the livenessProbe so that it's not failing anymore at the start, while waiting for django to be ready.

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@mwallschlaeger mwallschlaeger added the bug Something isn't working label Jun 29, 2024
@mwallschlaeger mwallschlaeger added this to the Release 1.2.2 milestone Jun 29, 2024
@mwallschlaeger mwallschlaeger self-assigned this Jun 29, 2024
…ll_nginx_container_when_using_externalscheme_https
@mwallschlaeger mwallschlaeger merged commit a9ceab7 into main Jul 10, 2024
3 checks passed
@mwallschlaeger mwallschlaeger deleted the issue_#190_Bug_nginx_livenessProbe_always_kill_nginx_container_when_using_externalscheme_https branch July 10, 2024 20:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant