[Part of #177] Feature: refector nginx deployment #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwallschlaeger
added
enhancement
ridoo
reviewed
Jul 2, 2024
| location /geoserver { | ||
| client_max_body_size {{ .Values.nginx.maxClientBodySize }}; | ||
|
|
||
| {{- if .Values.nginx.external_cors.enabled }} |
There was a problem hiding this comment.
You may consider removing CORS config at nginx completely, just in favor of configuring CORS via django-cors-headers.
There was a problem hiding this comment.
@AlexGacon any opinion on that from your side?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if ingress is enabled, this change will let
/geoserverand/catalogue/csw(.Values.pycsw.endpoint) be an individual path inside thekubernetes.ingressobject in geonode-k8s. This change will improve performance of traffic towardsgeoserverandpycswas this traffic does not traverse geonode-nginx container anymore,@AlexGacon external cors (.Values.nginx.external_cors.enabled) must now be set as
ingress.annotationsthis PR is not a full fix of issue #177 more like a partial fix so far.
Type of Change
Please select the relevant option:
Related Issue
If there is an existing issue related to this pull request, please reference it here.
ref #177
Checklist
Please ensure that your pull request meets the following requirements:
Additional Notes
Any additional information or context regarding the pull request can be provided here.
Thank you for creating this pull request