Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixes #145] Bug: Database connection issue when using postgres-operator #146

Conversation

mwallschlaeger
Copy link
Contributor

Description

fixes bug when using default database configuration with postgres-operator.

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #145

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@AlexGacon
Copy link
Collaborator

@mwallschlaeger using always the same name implies that you cannot ship all the secrets in one file. Is it not possible to have a different name for each password ?

@mwallschlaeger
Copy link
Contributor Author

@AlexGacon ok now I remember fully how postgres integration is implemented currently. Three different scenarios:

  1. using postgres-operator and doen't furhter care about database passwords
  2. using external_postgres and provide hostname, port and passwords via:
  • external_postgres.hostname , external_postgres.port, external_postgres.secret.postgres_password ...
  1. using external_postgres and provide credentials via a single secret file containing:
  • postgres_password, geonode_password, geodata_password

Currently scenario 1. broken. My fix breaks scenario 3., so i will do some furhter sepration to support the 3. usecase.

@AlexGacon
Copy link
Collaborator

Looking good to me.

Copy link
Collaborator

@AlexGacon AlexGacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

@mwallschlaeger mwallschlaeger merged commit c3d30d1 into main Feb 23, 2024
2 checks passed
@mwallschlaeger mwallschlaeger deleted the issue_#145_Bug_Database_connection_issue_when_using_postgres-operator branch February 23, 2024 15:32
@mwallschlaeger mwallschlaeger restored the issue_#145_Bug_Database_connection_issue_when_using_postgres-operator branch February 26, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Database connection issue when using postgres-operator
2 participants