Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of pull secrets #141

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

AlexGacon
Copy link
Collaborator

@AlexGacon AlexGacon commented Feb 8, 2024

Description

Manage optional definition of image pull secrets for each image of the stack.

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #140

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@AlexGacon
Copy link
Collaborator Author

@mwallschlaeger , I will prepare the documentation for a next release as soon as it is ok for you.

Copy link
Contributor

@mwallschlaeger mwallschlaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's awesome

@mwallschlaeger mwallschlaeger merged commit f7d74f2 into zalf-rdm:main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: allow to define imagePullSecrets for using private registry
2 participants