Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ending slash from NGINX_BASE_URL definition #137

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

AlexGacon
Copy link
Collaborator

@AlexGacon AlexGacon commented Jan 22, 2024

Description

With an external domain, the geoserver oauth is not working correctly: an error message complains about the redirect_uri which does not match what is registered in geonode, because of an additional /.

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #136

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@AlexGacon
Copy link
Collaborator Author

If ok, I can take care of preparing the documentation for a new release.

@AlexGacon
Copy link
Collaborator Author

@mwallschlaeger is it possible to have a review?

@mwallschlaeger mwallschlaeger merged commit 90e57f9 into zalf-rdm:main Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: geoserver oauth not working correctly
2 participants