Move starter proxy responsibilities into proxy set.

[diemol]

Comes from #527

[pearj]

/retest

[codecov-io]

Codecov Report

Merging #537 into master will decrease coverage by 19.51%.
The diff coverage is 44.16%.

@@              Coverage Diff              @@
##             master     #537       +/-   ##
=============================================
- Coverage     79.83%   60.32%   -19.52%     
+ Complexity      582      472      -110     
=============================================
  Files            33       36        +3     
  Lines          2742     2999      +257     
  Branches        234      249       +15     
=============================================
- Hits           2189     1809      -380     
- Misses          409     1052      +643     
+ Partials        144      138        -6

[diemol]

OK, so now Travis is passing!
We need to check the unit tests and see what has to be enabled again.

[diemol]

@dspasojevic I think the email account you used for the commits is not associated to your GitHub account, so the commits are not being associated to your GitHub user.

[dspasojevic]

Thanks for the heads up @diemol. I've linked my work accounts. It looks like the commits are correctly associated now.

[parberge]

@diemol Anything left to test or change now? Very excited about getting this merged and to get a new release of zalenium 😸

[diemol]

@peerster the thing is that some unit tests are failing now, and even if the integration tests are passing, I'd like to review the unit tests first :)
I'll try to check them during this week, but any help is appreciated. After that, I think we can be more confident to release.

[pearj]

I just had a peek at why the test is failing, it's because the autostartproxy isn't expecting the proxy to register, so it doesn't accept the proxy registration

[dspasojevic]

Thanks for looking @pearj. I added a SimpleRegistry that requires a bit less mocking for the other tests. I think that if I change that test to use it, it should pass. I'll give it a go.

[pearj]

👍

[pearj]

🚀

[dspasojevic]

Hi @diemol, with @pearj's help, I've fixed the failing unit tests. Sorry - I should have checked those before pushing up.

The tests in DockerSeleniumStarterRemoteProxyTest are still commented out. Which of those tests do you think are valuable? If you let me know, I will look at porting them.

Do you think that it would be good to write some additional integration tests (e.g. test killing containers in minikube, etc) rather than writing more unit tests that involve quite elaborate mocks?

[diemol]

👍

[pearj]

👍