Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

Improve logging with mdc #511

Merged
merged 3 commits into from
Apr 4, 2018

Conversation

dennisgranath
Copy link
Contributor

@dennisgranath dennisgranath commented Apr 4, 2018

Description

Use MDC to enrich logging.

  • Add desired capabilities as MDC fields when a request is added to queue
  • Add MDC field numberOfParallelCloudSessions when a new session is created towards a cloud provider
  • Option to provide your own logback.xml file

Motivation and Context

I want a dashboard that tells me how many parallel session we are using towards a cloud provider.
I also want to visualise what browsers that are used during testing.

How Has This Been Tested?

  • Unit test
  • Manual testing of browserstack proxy

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Apr 4, 2018

Codecov Report

Merging #511 into merge-511 will decrease coverage by 0.32%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             merge-511     #511      +/-   ##
===============================================
- Coverage         80.8%   80.48%   -0.33%     
+ Complexity         584      582       -2     
===============================================
  Files               32       32              
  Lines             2678     2685       +7     
  Branches           233      233              
===============================================
- Hits              2164     2161       -3     
- Misses             374      383       +9     
- Partials           140      141       +1

@diemol
Copy link
Contributor

diemol commented Apr 4, 2018

Hi @dennisgranath, thanks for the PR!

Let me merge that to a protected branch and then run all the CI tests to merge to master, I'll do that in a few hours.

@dennisgranath
Copy link
Contributor Author

@diemol Thanks!!! Really appreciate it!!

@diemol
Copy link
Contributor

diemol commented Apr 4, 2018

👍

@diemol diemol changed the base branch from master to merge-511 April 4, 2018 15:20
@elgalu
Copy link
Member

elgalu commented Apr 4, 2018

👍

@diemol diemol merged commit 3e0c620 into zalando:merge-511 Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants