Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

Changed fileName in RemoteLogDashboard to use testFileNameTemplate #1149

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

anuradha24
Copy link
Contributor

@anuradha24 anuradha24 commented Jan 31, 2020

Thanks for contributing to Zalenium! Please give us as much information as possible to merge this PR
quickly.

Description

Changed fileName in RemoteLogDashboard uploadFile object to use testFileNameTemplate

Motivation and Context

testFileNameTemplate is needed for the log files sent to Remote Dashboard to be able to associate them with a given test case
Fix for issue - #1148

How Has This Been Tested?

Tested end-to-end with our dashboard

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ileNameTemplate

Description : Fix for issue - zalando#1148
testFileNameTemplate is needed for the log files sent to Remote Dashboard to be able to associate them with a given test case
@anuradha24 anuradha24 changed the title Changed fileName in RemoteLogDashboard uploafFile object to use testF… Changed fileName in RemoteLogDashboard to use testFileNameTemplate Jan 31, 2020
@codecov-io
Copy link

Codecov Report

Merging #1149 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1149      +/-   ##
============================================
- Coverage     55.14%   55.02%   -0.13%     
- Complexity      681      697      +16     
============================================
  Files            58       61       +3     
  Lines          4573     4643      +70     
  Branches        429      436       +7     
============================================
+ Hits           2522     2555      +33     
- Misses         1819     1851      +32     
- Partials        232      237       +5

@diemol
Copy link
Contributor

diemol commented Mar 21, 2020

Thank you @anuradha24!
I am still waiting to see if we can merge #1085 before doing a release.

@diemol diemol merged commit be98235 into zalando:master Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants