continue syncing databases and extensions on err #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
Jan-M,
hughcapet,
idanovinda,
jopadi and
sdudoladov
as code owners
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #2198
For extensions it's possible they are dependent on one another. Thus, it could happen that syncing an extensions can fail because another extension listed in the manifest has not been installed yet. The go loop iterates in random order, so sometimes it might work but mostly it won't.
This PR tries to improve the sync of databases, prepared databases and schemas and extension. Taking the idea that is also used in other parts to collect error messages rather then erroring out immediately. In some places the loop must be continued.