Skip to content

Conversation

@yajo
Copy link
Contributor

@yajo yajo commented Feb 28, 2023

Problem description

In 30b6124 this update was forgotten. It is needed for logical backups of postgres 15 clusters, as seen in #1945 (comment).

The default value documented is different to the one actually used:

* **logical_backup_docker_image**
An image for pods of the logical backup job. The [example image](https://github.com/zalando/postgres-operator/blob/master/docker/logical-backup/Dockerfile)
runs `pg_dumpall` on a replica if possible and uploads compressed results to
an S3 bucket under the key `/spilo/pg_cluster_name/cluster_k8s_uuid/logical_backups`.
The default image is the same image built with the Zalando-internal CI
pipeline. Default: "registry.opensource.zalan.do/acid/logical-backup:v1.9.0"

Linked issues

Fixes #1945.

@moduon MT-1075

Checklist

Thanks for submitting a pull request to the Postgres Operator project.
Please, ensure your contribution matches the following items:

  • Your go code is formatted. Your IDE should do it automatically for you.
  • You have updated generated code when introducing new fields to the acid.zalan.do api package.
  • New configuration options are reflected in CRD validation, helm charts and sample manifests.
  • New functionality is covered by unit and/or e2e tests.
  • You have checked existing open PRs for possible overlay and referenced them.

In 30b6124 this update was forgotten. It is needed for logical backups of postgres 15 clusters, as seen in zalando#1945 (comment).

Fix zalando#1945.

@moduon MT-1075
@FxKu
Copy link
Member

FxKu commented Mar 2, 2023

👍

@jopadi
Copy link
Member

jopadi commented Mar 20, 2023

👍

@FxKu FxKu merged commit fd0092e into zalando:master Mar 20, 2023
@FxKu
Copy link
Member

FxKu commented Mar 20, 2023

Thanks @yajo. It will be bumped once again for the next release anyway - but a good reminder to not forget it again.

@yajo yajo deleted the bump-default-logical-backup-docker-image branch March 24, 2023 14:22
FxKu pushed a commit that referenced this pull request Apr 6, 2023
In 30b6124 this update was forgotten. It is needed for logical backups of postgres 15 clusters, as seen in #1945 (comment).

Fix #1945.

@moduon MT-1075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for PostgreSQL 15

3 participants