Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mandatory properties to .zappr #1886

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add mandatory properties to .zappr #1886

merged 2 commits into from
Sep 12, 2024

Conversation

kasmarian
Copy link
Member

@kasmarian kasmarian commented Sep 12, 2024 •
edited
Loading

Description

Add mandatory properties to .zappr

Motivation and Context

COMPR/pr-specification check fails on pull requests as stricter .zappr validation was enforced. This PR adds mandatory fields

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@kasmarian kasmarian added the bugfix Bug fixes and patches label Sep 12, 2024
@kasmarian
Copy link
Member Author

👍

@kasmarian kasmarian merged commit 9049142 into main Sep 12, 2024
3 of 4 checks passed
@kasmarian kasmarian deleted the fix-zappr branch September 12, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msdousti msdousti msdousti approved these changes

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

Assignees
No one assigned
Labels
bugfix Bug fixes and patches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasmarian @msdousti