Use writeTo() to buffer HttpEntity in httpclient5 #1701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
HttpEntity.writeTo()
instead of relying onEntityUtils.toByteArray()
to copy theOutputStream
of the HttpEntity.Motivation and Context
With a change in Spring Framework 6.1, HttpComponentsClientHttpRequest has an internal class BodyEntity, that is meant to not cache an
OutputStream
, but to provide a callback, that's used when theOutputStream
is required. The getContent() method throwsUnsupportedOperationException
.With this change, I'm using the
writeTo()
method to copy theOutputStream
, as for Logbook, buffering the stream is required.Addresses #1693
Types of changes
Checklist: