ensure truncation body filter is always last one #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasmarian
requested review from
whiskeysierra and
lukasniemeier-zalando
as code owners
|
lgtm |
ado-dao
reviewed
Aug 9, 2023
...-autoconfigure/src/main/java/org/zalando/logbook/autoconfigure/LogbookAutoConfiguration.java
Outdated
Show resolved
Hide resolved
|
👍 |
2 similar comments
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a truncation filter as the last one in the list of BodyFilters before creating Logbook.
Also remove a separate class for truncation as it's not useless.
Motivation and Context
This PR is a follow-up from #1592 to ensure that truncation always happens at the end.
Kudos to @ado-dao for spotting.
Types of changes
Checklist: