set: limit windows service size

Signed-off-by: Filip Weiss <[email protected]>
zalando · Oct 16, 2022 · 8976d18 · 8976d18
1 parent 5205e6f
commit 8976d18
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/keyring_windows.go b/keyring_windows.go
@@ -29,8 +29,14 @@ func (k windowsKeychain) Set(service, username, password string) error {
 		return ErrSetDataTooBig
 	}
 
-	// service may not exceed 32k
-	if len(service) > 1024*32 {
+	// service may not exceed 512 bytes (might need more testing)
+	if len(service) >= 512 {
+		return ErrSetDataTooBig
+	}
+
+	// service may not exceed 32k but problems occur before that
+	// so we limit it to 30k
+	if len(service) > 1024*30 {
 		return ErrSetDataTooBig
 	}