Fix #93 Do not require nakadi-producer.access-token-uri anymore #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ePaul
reviewed
Aug 10, 2018
README.md
Outdated
| @@ -136,6 +132,19 @@ spec: | |||
| privileges: [] | |||
| ``` | |||
|
|
|||
| If your application is running in Zalando`s stups environment (or you provide tokens via your own oAuth server) it needs | |||
There was a problem hiding this comment.
Zalando`s→Zalando's(please use apostroph and not backtick here).stups→STUPS.
ePaul
reviewed
Aug 10, 2018
README.md
Outdated
| If you do not use the STUPS Tokens library, you can implement token retrieval yourself by defining a Spring bean of type `org.zalando.nakadiproducer.AccessTokenProvider`. The starter will detect it and call it once for each request to retrieve the token. | ||
|
|
||
| #### Authentication in a non-Zalando environment | ||
| Please consult the [manual of Zalando's tokens library](https://github.com/zalando/tokens) for more configuration options (like `CREDENTIALS_DIR` or via environment variables. |
There was a problem hiding this comment.
Maybe this subsection should be above the one before, as it is also for the Tokens library?
ePaul
reviewed
Aug 10, 2018
README.md
Outdated
| @@ -144,9 +153,7 @@ If your Nakadi installation needs real scopes for submitting events, you can pro | |||
| nakadi-producer: | |||
| access-token-uri: https://token.auth.example.org/oauth2/access_token | |||
There was a problem hiding this comment.
Here the access-token-uri is still mentioned.
ePaul
reviewed
Aug 10, 2018
README.md
Outdated
|
|
||
| #### Authentication in a non-Zalando environment | ||
| Please consult the [manual of Zalando's tokens library](https://github.com/zalando/tokens) for more configuration options (like `CREDENTIALS_DIR` or via environment variables. | ||
|
|
||
| Since [July 2017](https://github.com/zalando/nakadi/pull/692), Nakadi (at least in the version operated at Zalando) doesn't require any scopes other than the pseudo-scope `uid` for writing events, [the authorization is instead based on event-type configuration using the service's uid](https://nakadi.io/manual.html#using_authorization). |
There was a problem hiding this comment.
Maybe this could be a subsection named "Scope configuration" or similar?
|
Did you consider doing also #10 on the way (i.e. recognizing an existing AccessToken bean if there is one, and not an access-token-uri?) |
ePaul
added
enhancement
auto-configuration
|
@ePaul I would keep that seperate for two reasons:
|
BGehrels
force-pushed
the
fake-access-toke-uri
branch
3 times, most recently
from
60ad44b
to
29ea738
Compare
BGehrels
force-pushed
the
fake-access-toke-uri
branch
from
29ea738
to
7ad0600
Compare
|
Fixed all your comments, i hope |
|
👍 |
ePaul
approved these changes
Aug 10, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #93 Do not require nakadi-producer.access-token-uri anymore