#23 Support using the library in a non-springboot project #33
Conversation
…hout any spring or third party tool dependency, one spring boot starter and one, that ties them all together
…ti module projects, so we remove this. mvnw verify should do the job, and travis by default falls back to ./mvnw install -DskipTests=true -Dmaven.javadoc.skip=true -B -V for the install step which seems fine
…l -DskipTests=true -Dmaven.javadoc.skip=true -B -V for the install step which executed the gpg plugin. this fails, because there is no gpg key. this commit adds -Dgpg.skip=true to it.
|
wohoo, build is green \o/ |
| this.eventTransmissionService = eventTransmissionService; | ||
| } | ||
|
|
||
| public void sendEvents() { |
There was a problem hiding this comment.
This method previously had a @Scheduled annotation. How is this done now?
There was a problem hiding this comment.
Readded it with 5ba13f1
|
Should we get a new section into the README like "how to use with non-springboot projects"? |
|
Would not add this now, maybe later when we have more experiences. Until then, i would consider it undocumented and experimental. |
|
fixed the comment |
| @@ -29,6 +29,7 @@ | |||
| import org.springframework.context.annotation.Configuration; | |||
| import org.springframework.context.annotation.Import; | |||
| import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate; | |||
| import org.springframework.scheduling.annotation.Scheduled; | |||
There was a problem hiding this comment.
I guess this import can now go away?
| @@ -73,7 +73,7 @@ public void testSnapshotSavedInBatches() { | |||
| // when snapshot returns 5 item stream | |||
| when(snapshotEventProvider.getSnapshot(PUBLISHER_EVENT_TYPE, null)).thenReturn(eventPayloads.subList(0, 3)); | |||
| when(snapshotEventProvider.getSnapshot(PUBLISHER_EVENT_TYPE, 2)).thenReturn(eventPayloads.subList(3, 5)); | |||
| when(snapshotEventProvider.getSnapshot(PUBLISHER_EVENT_TYPE, 5)).thenReturn(Collections.emptyList()); | |||
| //when(snapshotEventProvider.getSnapshot(PUBLISHER_EVENT_TYPE, 5)).thenReturn(Collections.emptyList()); | |||
| @@ -1,33 +0,0 @@ | |||
| {"groups": [ | |||
There was a problem hiding this comment.
This file is gone ... is it not needed anymore?
There was a problem hiding this comment.
I do not think it is desperately needed and it i really prone to run out of sync with the code pretty soon, so i deleted it.
…it obvious that we had an off-by-one-error here
|
👍 |
1 similar comment
|
👍 |
Splitted the project in three maven modules:
nakadi-producer) without any spring or third party tool dependency (which contains the core algorithms and a set of interfaces which can be implemented by using projects),nakadi-producer-spring-boot-starter, which adds autoconfiguration, DB setup and access, etc.) andThis will allow to use the core library in non-springboot projects (for #23), but it needs some manual configuration there. We will document this later (in a separate PR) when we have tried it in some internal projects.
It will also allow easier testing of the spring-boot-starter in test projects with different dependency configurations (in later PRs → #56).