This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Added annotations property to EventType schema #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryanarb
requested review from
mdedetrich,
itachi3,
pascalh and
gchudnov
as code owners
suryanarb
force-pushed
the
add_annotations_to_eventtype
branch
3 times, most recently
from
c7b4499
to
8c9a8f8
Compare
Pull Request Test Coverage Report for Build 3600390750
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3602739419
💛 - Coveralls |
suryanarb
force-pushed
the
add_annotations_to_eventtype
branch
from
8c9a8f8
to
93568d3
Compare
Signed-off-by: Suryanaraayan Balachandher <[email protected]>
suryanarb
force-pushed
the
add_annotations_to_eventtype
branch
from
93568d3
to
cb82dba
Compare
gchudnov
pushed a commit
that referenced
this pull request
Dec 2, 2022
Signed-off-by: Suryanaraayan Balachandher <[email protected]> Signed-off-by: Suryanaraayan Balachandher <[email protected]> Co-authored-by: Suryanaraayan Balachandher <[email protected]> Signed-off-by: Grigorii Chudnov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add placeholder in the EventType schema for the property "annotations" corresponding to the Nakadi API defined as per the following:
https://github.com/zalando/nakadi/blob/8f826fe0739c0232f3bf52510965aa7a36987cc2/docs/_data/nakadi-event-bus-api.yaml#L2890