Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Remove deprecated Jackson 2.7 property CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES #436

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

otrosien
Copy link
Member

@otrosien otrosien commented Oct 25, 2023

The next version of Jackson is going to remove this property, which will make Fahrschein fail (see current ci-latest build workflows)

References

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49ce46d) 69.69% compared to head (4a4c479) 69.73%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #436      +/-   ##
============================================
+ Coverage     69.69%   69.73%   +0.04%     
  Complexity      640      640              
============================================
  Files           116      116              
  Lines          2452     2452              
  Branches        181      181              
============================================
+ Hits           1709     1710       +1     
+ Misses          622      621       -1     
  Partials        121      121              
Flag Coverage Δ
unittests 69.73% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...va/org/zalando/fahrschein/DefaultObjectMapper.java 100.00% <100.00%> (ø)
...va/org/zalando/fahrschein/NakadiClientBuilder.java 90.90% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@otrosien otrosien marked this pull request as ready for review October 25, 2023 12:29
@otrosien otrosien changed the title Remove usage of deprecated Jackson 2.7 property CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES Remove deprecated Jackson 2.7 property CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES Oct 25, 2023
@otrosien
Copy link
Member Author

👍

1 similar comment
@mesut
Copy link
Collaborator

mesut commented Oct 25, 2023

👍

@otrosien otrosien merged commit ab6adc0 into main Oct 25, 2023
3 checks passed
@otrosien otrosien deleted the jackson-latest-fix branch October 25, 2023 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants