Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Add Spring Boot Starter #402

Merged
merged 8 commits into from
Jul 11, 2023
Merged

Add Spring Boot Starter #402

merged 8 commits into from
Jul 11, 2023

Conversation

rob-h-w
Copy link
Collaborator

@rob-h-w rob-h-w commented Jun 30, 2023 •
edited by otrosien
Loading

Integration for Fahrschein.

Follow-up tasks:

  • Upgrade to Spring Boot 3
  • Get rid of Lombok
  • Check usage of Guava (potentially copy&paste some code and get rid of the dependency)
  • Review Jackson configuration & jackson module dependencies
  • Pull out Micrometer support

WIP Add Spring Boot Starter
f451c2a 
Integration for Fahrschein.

Currently the Java version is resolving incorrectly & `forbiddenApisMain`
fails.
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 66.99% and project coverage change: +0.23 🎉

Comparison is base (53b5209) 67.53% compared to head (6901e54) 67.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #402      +/-   ##
============================================
+ Coverage     67.53%   67.77%   +0.23%     
- Complexity      431      601     +170     
============================================
  Files            77      111      +34     
  Lines          1805     2408     +603     
  Branches        150      176      +26     
============================================
+ Hits           1219     1632     +413     
- Misses          484      651     +167     
- Partials        102      125      +23
Flag Coverage Δ
unittests 67.77% <66.99%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/zalando/spring/boot/fahrschein/config/Ratio.java 0.00% <0.00%> (ø)
...hein/nakadi/config/MicrometerMetricsCollector.java 0.00% <0.00%> (ø)
...schein/nakadi/config/FahrscheinNakadiConsumer.java 4.10% <4.10%> (ø)
...do/spring/boot/fahrschein/nakadi/config/OAuth.java 12.50% <12.50%> (ø)
...hrschein/nakadi/config/DefaultNakadiPublisher.java 33.33% <33.33%> (ø)
...ot/fahrschein/nakadi/config/properties/Merger.java 50.00% <50.00%> (ø)
...rschein/nakadi/config/properties/ThreadConfig.java 50.00% <50.00%> (ø)
...schein/nakadi/config/properties/BackoffConfig.java 55.55% <55.55%> (ø)
...hein/nakadi/config/properties/PublisherConfig.java 57.14% <57.14%> (ø)
...rschein/nakadi/config/properties/JitterConfig.java 60.00% <60.00%> (ø)
... and 24 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rob-h-w rob-h-w changed the title WIP Add Spring Boot Starter Add Spring Boot Starter Jul 11, 2023
@rob-h-w rob-h-w marked this pull request as ready for review July 11, 2023 10:21
@otrosien
Copy link
Member

👍

1 similar comment
@rob-h-w
Copy link
Collaborator Author

rob-h-w commented Jul 11, 2023

👍

@rob-h-w rob-h-w merged commit b436d89 into main Jul 11, 2023
@rob-h-w rob-h-w deleted the add-spring-boot-starter branch July 11, 2023 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rob-h-w @codecov-commenter @otrosien