This repository has been archived by the owner on May 3, 2024. It is now read-only.
Add documentation #315
Merged
Add documentation #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otrosien
reviewed
Apr 5, 2022
fahrschein/src/main/java/org/zalando/fahrschein/EventPublishingException.java
Outdated
Show resolved
Hide resolved
otrosien
reviewed
Apr 5, 2022
fahrschein/src/main/java/org/zalando/fahrschein/NakadiClient.java
Outdated
Show resolved
Hide resolved
otrosien
reviewed
Apr 5, 2022
fahrschein/src/main/java/org/zalando/fahrschein/NakadiClient.java
Outdated
Show resolved
Hide resolved
otrosien
reviewed
Apr 5, 2022
| * @param baseUri that we try to connect to | ||
| * @param clientHttpRequestFactory that we use for the execution of our HTTP Requests. | ||
| * @return A builder to initialize the client. Can be further modified later. | ||
| */ | ||
| public static NakadiClientBuilder builder(URI baseUri, RequestFactory clientHttpRequestFactory) { |
There was a problem hiding this comment.
as part of this PR simplify the var naming to requestFactory?
Co-authored-by: Oliver Trosien <[email protected]>
…gException.java Co-authored-by: Oliver Trosien <[email protected]>
otrosien
reviewed
Apr 29, 2022
…e the chance to treat it dedicated.
Co-authored-by: Oliver Trosien <[email protected]>
…mentation # Conflicts: # fahrschein/src/main/java/org/zalando/fahrschein/NakadiClient.java
|
👍 |
otrosien
reviewed
May 4, 2022
fahrschein/src/main/java/org/zalando/fahrschein/EventPublishingException.java
Outdated
Show resolved
Hide resolved
|
👍 |
1 similar comment
|
👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start documenting public classes and methods with Javadoc
Closes #241 , closes #131