This repository has been archived by the owner on May 3, 2024. It is now read-only.
toString method for MetaData #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlGreed
commented
Dec 19, 2019
•
AlGreed
commented
- added toString method for MetaData to get a string representation of such objects in logs
- added "dist: trusty" to .travis.yml to be able to use oraclejdk8 further. Otherwise we need to change jdk to oraclejdk8, for example.
|
👍 |
|
@whiskeysierra @jhorstmann |
|
👍 |
|
@whiskeysierra Could you please merge it? And i will prepare a PR with release version. |
|
Normally I would advise against putting larger toString outputs into log messages and instead log only specified fields, but a toString also helps during debugging, so LGTM. |
jhorstmann
approved these changes
Jan 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.