This repository was archived by the owner on Jun 28, 2024. It is now read-only.
Update filter type to allow synchronous filters#100
Merged
shuhei merged 2 commits intozalando-incubator:masterfrom Jan 28, 2020
Merged
Update filter type to allow synchronous filters#100shuhei merged 2 commits intozalando-incubator:masterfrom
shuhei merged 2 commits intozalando-incubator:masterfrom
Conversation
Contributor
Author
|
Is this a breaking change? It might be a breaking change only for users who use filters outside of the |
Contributor
|
This is just a type fix.The current code already converts everything to promise during the filter chain handling. |
Contributor
|
👍 |
Contributor
|
We should refactor that part of the code with async await and skip useless promise posting as an optimization. |
Contributor
Author
|
👍 |
Contributor
|
It think this relates to this never ending discussion about Awaited type |
Contributor
Author
|
Published as 0.11.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating
ServiceClientRequestFiltertype to allow synchronous filter methods. In the implementation, they can return a non-promise value as written in README and tested in the unit tests.