change deployment service VPAs to InPlaceOrRecreate#10959
Merged
Conversation
tcondeixa
added
minor
added 5 commits
April 7, 2026 23:12
…o 2 to force VPA and be aligned with other deployments
tcondeixa
changed the title
Contributor
Author
|
@linki can you tell me the e2e test that was failing? I did not have any issue when I validate it in my pet cluster |
added 5 commits
April 15, 2026 09:58
Contributor
Author
|
The e2e test excluded as part of the kubernetes 1.35 will be addressed in a separated PR to unblock the validation with this use-case. |
Contributor
Author
|
👍 |
Contributor
Author
|
👍 |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change deployment service VPAs to InPlaceOrRecreate mode
This feature is GA in Kubernetes 1.35 that we are finishing the rollout soon.
The default
resizePolicyisrestart, so it's not require for cpu and memory (https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/#container-resize-policies)The deployment-service-controller is not 100% resilient to redeployments (we need to solve this later), so trying to do a in-place replacement should reduce the probability of issues for deployments done by users. The adjustments of memory/cpu should be small and incremental with VPA, so most of the cases should be covered by in-place replacement and we should see a low number of Recreate events.
I'm also changing the default resources from deployment-service-status-service for more sane defaults (only one the first deployment)
I'm also changing the replicas of the deployment-service-status-service to 2 to force VPA to work and see changes, this also makes this deployment aligned with the other deployments (2 replicas)
Tests
I tested this in a pet cluster and it worked by doing a inPlace without creating new pods.
The prometheus metrics also show the total of inPlace done as expected for status-service (vpa_updater_in_place_updated_pods_total = 2)