worker: prevent SSL policy update loop on shared load balancers#788
Merged
Conversation
In #774, update LB in-place was introduced. However, it was also introducing the following bug -> Ingress A has a custom SSL policy -> Ingress B uses the default SSL policy -> Since Ingress B doesn't have the annotation we will allow it through as `(ingress.HasSSLPolicyAnnotation && l.sslPolicy != ingress.SSLPolicy)` doesn't apply -> So we add both ingresses to LB then later override LB SSL policy with new ingress SSL policy (default one) Later `inSync` will revert to the old SSL policy and we go into infinite loop. Adding the new tag will help keep in-place updates, while blocking mismatch ingresses from landing on the same LB Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Contributor
|
👍 |
ayruslore
approved these changes
Apr 23, 2026
Member
Author
|
fyi @lambertpandian |
Contributor
Thanks for the fix and thanks for updating me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #774, update LB in-place was introduced. However, it was also introducing the following bug
-> Ingress A has a custom SSL policy
-> Ingress B uses the default SSL policy
-> Since Ingress B doesn't have the annotation we will allow it through as
(ingress.HasSSLPolicyAnnotation && l.sslPolicy != ingress.SSLPolicy)doesn't apply-> So we add both ingresses to LB then later override LB SSL policy with new ingress SSL policy (default one)
Later
inSyncwill revert to the old SSL policy and we go into infinite loop.Adding the new tag will help keep in-place updates, while blocking mismatch ingresses from landing on the same LB