Integrate jest-axe to enable a11y assertions in unit & integration tests#70
Merged
zainfathoni merged 4 commits intomasterfrom Aug 23, 2019
Merged
Integrate jest-axe to enable a11y assertions in unit & integration tests#70zainfathoni merged 4 commits intomasterfrom
zainfathoni merged 4 commits intomasterfrom
Conversation
andriawan
force-pushed
the
feature/a11y
branch
from
51f44c4 to
246edeb
Compare
andriawan
force-pushed
the
feature/a11y
branch
from
246edeb to
7f1db21
Compare
zainfathoni
requested changes
Aug 23, 2019
src/components/__test__/App.test.js
Outdated
| const { container } = render(<App />) | ||
| const results = await axe(container) | ||
| expect(results).toHaveNoViolations() | ||
| cleanup() |
Owner
There was a problem hiding this comment.
We don't need this line, because it will be automatically called since this point: testing-library/react-testing-library#430
Collaborator
Author
There was a problem hiding this comment.
just remove cleanup() line?
src/components/__test__/App.test.js
Outdated
| import React from 'react' | ||
| import App from '../App' | ||
|
|
||
| expect.extend(toHaveNoViolations) |
Owner
There was a problem hiding this comment.
We can automatically extend the expect API in every tests automatically by simply adding a single line in our setupTests.js file
zainfathoni
approved these changes
Aug 23, 2019
zainfathoni
changed the title
jest-axe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on task #55