-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images messed up in live version (gluon.mxnet.io), but look good in Github version #552
Comments
@vitali-fedulov can you include a screenshot with specification to the specific images out of place? It looks fine on my browser. What browser are you using? Desktop/mobile? Can you try a different one to be sure? |
nice catch. It looks like it's this issue with Sphinx: it only happens when the "alt" tag for an image is an empty string. i see a few empty alt tags, so it could be useful to try to fill those in with some relevant text. if you want to give it a go and try adding alt image text feel free to submit a PR and i can take a look. if not, I'll leave this issue open and someone, myself included might be able to get to it |
Fixing messed up pictures in Live version: zackchase#552 Let's try to push this change to live. If it is indeed the reason, I can check all other images in other chapters.
@vitali-fedulov Looks like the merge fixed the issue, Thank you! I'll let you double check and close off this issue. |
It looks much better, except it now has a block of same dog image instead
of mix of dogs and cats.
It seems the issue is somewhat more complicated. In the end adding the alt
tags is a temporary solution not fixing the root problem with the document
conversion tool. The tool probably has object indexing implementation wrong.
I will not have time to look more until middle next week. Maybe you have
time to?
…On Sat, 1 Dec 2018, 22:09 Vishaal Kapoor, ***@***.***> wrote:
@vitali-fedulov <https://github.com/vitali-fedulov> Looks like the merge
fixed the issue, Thank you! I'll let you double check and close off this
issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#552 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AqngCNPnGa7Q42Deb618NRksFhIEJG1Dks5u0vABgaJpZM4Y662x>
.
|
I think this will need to be fixed within Sphinx (possibly version upgrade). Leaving this issue open. |
Images are in wrong order/position on page:
https://gluon.mxnet.io/chapter01_crashcourse/introduction.html
But all good on corresponding Github:
https://github.com/zackchase/mxnet-the-straight-dope/blob/master/chapter01_crashcourse/introduction.ipynb
The text was updated successfully, but these errors were encountered: