Skip to content

feat: add sentry mode switch to fix issue #43#61

Merged
alandtse merged 1 commit into
zabuldon:masterfrom
hobbe:feat/sentry-mode
Mar 15, 2020
Merged

feat: add sentry mode switch to fix issue #43#61
alandtse merged 1 commit into
zabuldon:masterfrom
hobbe:feat/sentry-mode

Conversation

@hobbe
Copy link
Copy Markdown
Contributor

@hobbe hobbe commented Mar 5, 2020

Add a switch to enable/disable sentry mode for Tesla vehicle in Home Assistant. This should fix issue #43.

@tobbensoft
Copy link
Copy Markdown

Nice :)

Doesn't this need a HA switch update to work? Is that available to try?

@hobbe
Copy link
Copy Markdown
Contributor Author

hobbe commented Mar 9, 2020

@tobbensoft, this will need an update to the Tesla component in HA, including a teslajsonpy library update and a new switch.

@alandtse
Copy link
Copy Markdown
Collaborator

Oooh awesome. I'll merge it in. I'll be doing a dependency bump in HA but leave it to you to add the component in HA.

@alandtse alandtse merged commit c574ab0 into zabuldon:master Mar 15, 2020
@alandtse
Copy link
Copy Markdown
Collaborator

@hobbe Thanks again!
I didn't look at the code too closely before merging as I was super excited to see someone helping, but can you submit a PR to remove the checks for the current sentry state in case the known state isn't accurate? It's the reason for my latest PR #64 and prompted by the bug here.

@hobbe hobbe deleted the feat/sentry-mode branch March 17, 2020 10:07
@hobbe
Copy link
Copy Markdown
Contributor Author

hobbe commented Mar 17, 2020

@hobbe Thanks again!
I didn't look at the code too closely before merging as I was super excited to see someone helping, but can you submit a PR to remove the checks for the current sentry state in case the known state isn't accurate? It's the reason for my latest PR #64 and prompted by the bug here.

@alandtse, PR #66 submitted 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants