option to truncate dn #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoopex
reviewed
Nov 12, 2023
There was a problem hiding this comment.
Welcome to the circle of contributors :-)
I added some comments to your PR.
Can you combine your changes in a single and descriptive commit message?
(see also https://jvns.ca/blog/2023/11/06/rebasing-what-can-go-wrong-/ .... i.e. by git rebase -i HEAD^^, add "s" to all your commits except the first one and git push --force is your friend)
zabbix-ldap.conf.example
Outdated
| @@ -25,6 +25,7 @@ filtergroup = (&(objectClass=posixGroup)(cn=%s)) | |||
| filteruser = (&(objectClass=posixAccount)(uid=%s)) | |||
| groupattribute = memberUid | |||
| userattribute = uid | |||
| truncatedn = false | |||
There was a problem hiding this comment.
Can you add this to the Readme instead?
(Including why this is needed and a n example of the truncation)?
GOID1989
force-pushed
the
GOID1989-patch-1
branch
2 times, most recently
from
fdd4b2c to
5344f2e
Compare
|
check it |
scoopex
reviewed
Nov 12, 2023
README.md
Outdated
| @@ -90,6 +90,7 @@ In order to use the *zabbix-ldap-sync* script we need to create a configuration | |||
| * `filteruser` = The ldap filter to get the users in OpenLDAP mode, by default `(&(objectClass=posixAccount)(uid=%s))` | |||
| * `groupattribute` = The attribute used for membership in a group in OpenLDAP mode, by default `memberUid` | |||
| * `userattribute` = The attribute for users in openldap mode, by default `uid` | |||
| * `truncatedn` - If set to true distinguished name (DN) will be truncated, by default false. Group members usually defined as `full-path-DN` not clear `login` and it's breaks search. Example: `uid=testuser,cn=users,cn=accounts,dc=example,dc=com` cut to `uid=testuser` | |||
There was a problem hiding this comment.
Thanks :-)
Sorry about the nitpick :-) Lets make this to one additional level more clearer.
`truncatedn` - If set to true the distinguished name (DN) will be truncated to the first component (by default false). Group members are usually defined as `full-path-DN`. If your ldap server just uses the `login` names to reference group members (i.e. FreeIPA) you can use this functionality to solve problems with broken searches. Example: `uid=testuser,cn=users,cn=accounts,dc=example,dc=com` cut to `uid=testuser`
5344f2e to
256b894
Compare
|
Many thanks!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.