Skip to content

Fix compiler warnings (gcc: -Wsign-compare) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
z4kn4fein merged 1 commit into from
Apr 14, 2023
Merged

Fix compiler warnings (gcc: -Wsign-compare) #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/semver/semver.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ namespace semver
prerelease_descriptor increment() const {
std::vector<prerelease_part> new_parts = (m_parts);
int last_numeric_index = -1;
for (int i = 0; i < new_parts.size(); ++i) {
for (size_t i = 0; i < new_parts.size(); ++i) {
if (new_parts[i].numeric()) last_numeric_index = i;
}
if (last_numeric_index != -1) {
Expand All @@ -159,7 +159,7 @@ namespace semver
auto other_size = other.m_parts.size();

auto count = std::min(this_size, other_size);
for (int i = 0; i < count; ++i) {
for (size_t i = 0; i < count; ++i) {
int cmp = m_parts[i].compare(other.m_parts[i]);
if (cmp != 0) return cmp;
}
Expand Down Expand Up @@ -370,4 +370,4 @@ namespace semver
}
}

#endif // Z4KN4FEIN_SEMVER_H
#endif // Z4KN4FEIN_SEMVER_H